Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Helm support #1074

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Drop Helm support #1074

merged 1 commit into from
Mar 22, 2024

Conversation

michalvavrik
Copy link
Member

Summary

We discussed it with team and our disabled tests for Quarkus Helm without product support doesn't bring anything, Helm support needs to be reworked when Quarkus helm is supported in RHBQ. Windows CI is now failing over scoop installation and this PR fixes it.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik mentioned this pull request Mar 21, 2024
Merged
10 tasks
@michalvavrik michalvavrik requested a review from gtroitsk March 21, 2024 23:17
@michalvavrik michalvavrik mentioned this pull request Mar 21, 2024
Merged
11 tasks
gtroitsk
gtroitsk approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@gtroitsk gtroitsk merged commit 50f5984 into quarkus-qe:main Mar 22, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/drop-helm-from-ci branch March 22, 2024 10:44
@michalvavrik michalvavrik mentioned this pull request Apr 23, 2024
Merged
11 tasks
@mjurc mjurc added the triage/backport-1.4? Quarkus 3.8 stream label Apr 29, 2024
@michalvavrik michalvavrik removed the triage/backport-1.4? Quarkus 3.8 stream label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtroitsk gtroitsk gtroitsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalvavrik @gtroitsk @mjurc